Skip to content

Conversation

hdeshev
Copy link
Contributor

@hdeshev hdeshev commented Sep 6, 2016

  • Use ONLY the official bundles when importing code. No imports from
    @angular/core/src/... since those are incompatible ES6 modules now.
  • Copy a bunch of private NG2 APIs that are not exported by the
    bundles:
    • facade/lang + facade/collection
    • parse5_adapter
    • Renderer CONTENT_ATTR CSS constant
    • AnimationDriver interface definition
    • url_tree -> containsTree from @angular/router
    • private_import_core, private_import_platform-browser,
      private_import_compiler
  • DetachedLoader no longer loading stuff inside a child ViewContainerRef
  • DetachedLoader now properly using component factories.

TODO

  • Router demos have issues - exceptions when navigating back, clear history not navigating or crashing too.
  • Migrate tests project
  • Review the child ViewTemplateRef removal in DetachedLoader //cc @vakrilov

- Use *ONLY* the official bundles when importing code. No imports from
`@angular/core/src/...` since those are incompatible ES6 modules now.
- Copy a bunch of private NG2 APIs that are not exported by the
bundles:
  - facade/lang + facade/collection
  - parse5_adapter
  - Renderer `CONTENT_ATTR` CSS constant
  - AnimationDriver interface definition
  - url_tree -> `containsTree` from `@angular/router`
  - `private_import_core`, `private_import_platform-browser`,
    `private_import_compiler`
- DetachedLoader no longer loading stuff inside a child ViewContainerRef
- DetachedLoader now properly using component factories.
- Lazy require animation driver module in renderer to work around a
  circular import issue in tns-core-modules.
- Router pushState now called before new component activation. Update
  location strategy hacks to accommodate that.
@hdeshev hdeshev merged commit 0bc5621 into master Sep 9, 2016
@hdeshev hdeshev deleted the hdeshev/ng-rc6 branch September 9, 2016 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant