Skip to content

Fix(page-router-outlet): make page-router-outlet lazy-loadable #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 16, 2016
Merged

Fix(page-router-outlet): make page-router-outlet lazy-loadable #530

merged 7 commits into from
Nov 16, 2016

Conversation

sis0k0
Copy link
Contributor

@sis0k0 sis0k0 commented Nov 11, 2016

No description provided.

@sis0k0 sis0k0 force-pushed the vlaeva/lazy-loadable-page-router-outlet branch from 512c495 to a40a71c Compare November 11, 2016 15:35
hdeshev
hdeshev suggested changes Nov 14, 2016
View reviewed changes
Copy link
Contributor

@hdeshev hdeshev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add an Appium test for lazy loaded modules?

@vakrilov
Copy link
Contributor

lazy-load all the things

@sis0k0 sis0k0 merged commit 8efa136 into master Nov 16, 2016
@sis0k0 sis0k0 deleted the vlaeva/lazy-loadable-page-router-outlet branch November 22, 2016 11:38
@fricker fricker mentioned this pull request Nov 23, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hdeshev hdeshev hdeshev approved these changes

@vakrilov vakrilov vakrilov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sis0k0 @vakrilov @hdeshev