Call the runtime require function instead of the webpack's one in ns-module-factory-loader #624
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
ns-module-factory-loader
contains dynamic require call, when it is webpacked, a context module is generated for it. By default, when a module is dynamically required by a context module it must reside in the same directory as the context module in order to be resolved by thewebpack
's require. This means that after this change in the sdk examples, the example app will crash withModule not found
when a module that is not in the same directory asns-module-factory-loader.ts
is required.This commit makes
ns-module-factory-loader
"webpackable" and "snapshotable" by replacing the call to the webpackrequire
function (webpack
replaces allrequire(..)
calls to__webpack_require(..)
calls) to call to the runtime'srequire
function.