fix(animated-circle): allow animated prop to enable/disable animation on android (#552)

kefahB · web-flow · commit 1fb7e70f009a · 2023-11-26T17:10:49.000-08:00
diff --git a/packages/animated-circle/index.android.ts b/packages/animated-circle/index.android.ts
@@ -1,8 +1,17 @@
-import { Color } from '@nativescript/core';
+import { Color, Property, booleanConverter } from '@nativescript/core';
 import { AnimatedCircleCommon, barColorProperty, rimColorProperty, spinBarColorProperty } from './common';
 
 declare const at;
 
+export const animatedProperty = new Property<AnimatedCircle, boolean>({
+    name: 'animated',
+    valueChanged: (target, old, newValue) => {
+        target.updateAnimatedCircle();
+    },
+    defaultValue: false,
+    valueConverter: booleanConverter
+});
+
 export class AnimatedCircle extends AnimatedCircleCommon {
 	private _android: any;
 	private _progress = 0;
@@ -69,7 +78,12 @@ export class AnimatedCircle extends AnimatedCircleCommon {
 
 	set progress(value: number) {
 		this._progress = value;
-		this.android?.setValueAnimated(this._progress);
+		if(this.animated) {
+			this.android?.setValueAnimated(this._progress);
+		}
+		else {
+			this.android?.setValue(this._progress);
+		}
 	}
 
 	get progress(): number {
@@ -94,15 +108,6 @@ export class AnimatedCircle extends AnimatedCircleCommon {
 		return this._animationDuration;
 	}
 
-	set animated(value: boolean) {
-		this._animated = Boolean(value);
-		this.updateAnimatedCircle();
-	}
-
-	get animated(): boolean {
-		return this._animated;
-	}
-
 	set maxValue(value: number) {
 		this._maxValue = value;
 		this.android?.setMaxValue(this.maxValue);
@@ -318,3 +323,5 @@ export class AnimatedCircle extends AnimatedCircleCommon {
 		}
 	}
 }
+
+animatedProperty.register(AnimatedCircle);
