Fix animated miss implemented for android #552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CatchABus
reviewed
Nov 26, 2023
CatchABus
reviewed
Nov 26, 2023
CatchABus
requested changes
Nov 26, 2023
CatchABus
reviewed
Nov 26, 2023
CatchABus
requested changes
Nov 26, 2023
Remove old getter and setter
CatchABus
reviewed
Nov 26, 2023
CatchABus
requested changes
Nov 26, 2023
|
@kefahB Let me also point out this line: https://github.com/NativeScript/plugins/blob/main/packages/animated-circle/index.android.ts#L42 |
Add typings
|
Thanks @CatchABus I'll merge and fix up last condition within initNativeView there, thanks @kefahB for effort here! |
|
Published in 1.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @NathanWalker,
The
animatedproperty was miss implemented for android, the circle is animated even if we satanimated = falseand make the animation restarted for each iteration because of the continuous update of theprogressproperty, then the last one is animated but too lately.