fix(datetimepicker): spinner & calendar ipads display issue #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an issue with the datetimepicker plugin. On iOS iPads the DatePicker was almost completly cut off in Spinner mode. Only part of the month was visible so it was unusable. Also, in Calendar mode, the left and right sides were partially clipped off. This commit fixes those issues on iOS tablets. Also, in the demo and demo-angular apps, added an example to show spinner mode on iOS v14+ bc with 14+ the default is the calendar mode so the examples only showed calendar mode in iOS 14+. Fixes NativeScript#128
NathanWalker
approved these changes
Sep 27, 2021
|
Released in 2.1.7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue with the datetimepicker plugin. On iOS iPads
the DatePicker was almost completly cut off in Spinner mode. Only part
of the month was visible so it was unusable. Also, in Calendar mode, the
left and right sides were partially clipped off. This commit fixes those
issues on iOS tablets.
Also, in the demo and demo-angular apps, added an example to show
spinner mode on iOS v14+ bc with 14+ the default is the calendar mode so
the examples only showed calendar mode in iOS 14+.
Fixes #128