Skip to content

feat(geolocation) : Using coarse location on Android 12 #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 11, 2023

Conversation

INiiS
Copy link
Contributor

@INiiS INiiS commented Oct 24, 2022

Should fix #196

This is my first PR on the project, I hope it follows correctly any guideline, or recommendation.

In Android 12, the user can now choose between fine location & coarse location.
The official android guidelines recomment to request both in the same request, and then handle the result as seen fit.
I tried to follow these guidelines in my implementation.

I closed the previous PR, due to problems on my side with settings correctly my identity on Git. Should be resolved now.

@cla-bot
Copy link

cla-bot bot commented Oct 24, 2022

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @INiiS.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

@INiiS
Copy link
Contributor Author

INiiS commented Oct 24, 2022

@cla-bot check

@cla-bot cla-bot bot added the cla: yes label Oct 24, 2022
@cla-bot
Copy link

cla-bot bot commented Oct 24, 2022

The cla-bot has been summoned, and re-checked this pull request!

@jarmani
Copy link

jarmani commented Apr 10, 2023

Any news on this one ? Thanks !

@NathanWalker
Copy link
Contributor

Hi @INiiS and @jarmani, we began switching the transient permissions plugin usages throughout various plugins to:
https://github.com/nativescript-community/perms
and was reason we had delayed here. Let’s merge this and do a patch rather and we can switch the transient perms usage later. Thank you for this contribution.

@NathanWalker NathanWalker merged commit 62e4ffa into NativeScript:main Apr 11, 2023
@NathanWalker
Copy link
Contributor

Published with 8.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[@nativescript/geolocation] android 12: No location is returned if the new approximate location option is selected
3 participants