-
-
Notifications
You must be signed in to change notification settings - Fork 119
feat(local-notifications): allow requesting send notifications permission on Android 13+ devices #472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(local-notifications): allow requesting send notifications permission on Android 13+ devices #472
Conversation
Hello @NathanWalker, any chance this getting merged anytime soon? Thanks! |
@agonper thank you so much for this! Let’s switch to making transient on https://github.com/nativescript-community/perms as a better permissions handler. If able to switch up would be amazing but lemme know, otherwise we could merge and I could switch up in couple days to publish a minor bump. |
Hello @NathanWalker, you are welcome! Thanks for the reply. I checked the solution you're suggesting for permissions handling, but I saw in the docs that asking for notification delivery permissions in Android is not yet supported by the community alternative. Am I wrong? |
Let's confirm with @farfromrefug and we can help add it there if needed. |
Looks like it's already there 👍 https://github.com/nativescript-community/perms/blob/master/src/perms/index.android.ts#L144 |
…d permission handling
Oh, I did not check the code, just the README 😄 Done! Switched to the suggested solution. If there's anything else, please let me know. |
Sweet! nice work @agonper 🤗 |
6.1.0 published with the addition. |
Great! Thanks for the compliment @NathanWalker! I tried to install the new version in one of my projects, however, it seems that something happened during the release. The android aar file is missing in the npm package now: Could you have a look please? Thanks! |
Hmm @agonper will look in moment and publish patch shortly. |
I can confirm it's solved! Thank you very much @NathanWalker for the quick check!! |
Tried to use this with the most recent version of local-notifications but it seems like it is not possible again (i also see that the changes to the readme made in this pr were reverted by the pr in https://github.com/NativeScript/plugins/pull/458/files) |
This PR updates the local-notifications plugin for hasPermission and requestPermission to work as expected on Android 13+ devices (asking for the corresponding permission). The behaviour is equivalent to that of iOS.
Fixes #336