This repository was archived by the owner on Mar 21, 2019. It is now read-only.
fix(cache-images): respect decodeWidth and decodeHeight when caching images #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 13, 2018 11:29
…eight/decodeWidth.
MartoYankov
approved these changes
Mar 14, 2018
vakrilov
approved these changes
Mar 15, 2018
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
decodeHeightanddecodeWidthNode: Currently we are using the same cached image for single uri (showing the same picture on different pages e.g.) regardless the
decodeHeight/decodeHeightproperties. The image quality is defined by the first uri using and itsdecodeHeight/decodeHeight.