LFI vuln (v1) #319
Open
LFI vuln (v1) #319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implemented LFI vulnerability where only double url-encoded with nested traversal works
So, to access path like "../file.py", the parameter that needs to be passed is "%252E%252E%252E%252F%252E%252Ffile.py", which translates to "..././file.py"
[More safeguards can be added to make LFI even more difficult]
Added verbose error messages to help understand what kind of path will bypass checks
Added download service report functionality where this vulnerability is injected
Limited file storage to 50 pdfs (configurable) to avoid filling the disk space
Testing
Local testing
Documentation
Make sure that you have documented corresponding changes in this repository.
Checklist: