DayTwo refactor + CLI #1
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DayTwo
to use anEither String
to handle parse errors instead of theN*
constructors.first
fromBifunctor
was used to augment theString
error message with context.traverse
was used to process all thelines
and short-circuit on first error_ <$> _ <*> _
) was used to process both sides of the round and pass them to theRound
Vs
constructor. LYAH has a good section on applicative style[Round]
is preferable toRounds
)Round
a properdata
type + used an infixVs
constructor. This just looks nice :)LambdaCase
and used it quite a bit. It's a good syntax extension to learn!I also made
app/Main.hs
an entrypoint for all the various days'main
s. It parses the day number as the first argument, and then calls the correct daymain
with the rest of the args. Here's some example usage: