Implement new Exporter interface for bundled exporters #6797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- replace Properties with Map<String, String> - add default implementations for both new and old signature - add helper utilities
Adapted by tfmorris to the master (3.x) branch
- Run refine lint & whitespace cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6419. Based on @karindev 's work in #6460 adapted to the modified interface in #6796 (which is a prerequisite for this).
Changes proposed in this pull request:
NOTE: Compatibility is only provided for OpenRefine calling legacy exporters. There is no compatibility for a legacy third party framework (if any such frameworks exist) to call via the old API exporters which implement the new API
TODO: We probably need a test exporter which uses the old API so that we can confirm API compatibility on an ongoing basis.
Marked as Draft until I investigate the above ToDo