🩹 [Patch]: Refactor Build-PSModule action without Github-Script #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g and update artifact paths
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the Build-PSModule GitHub Action to drop the GitHub-Script wrapper, invoke the PowerShell build script directly, and simplify output and URI handling.
- Switches from
uses: PSModule/GitHub-Script@v1toshell: pwshwith arunblock inaction.yml - Updates outputs to use
$env:GITHUB_OUTPUTinstead ofSet-GitHubOutput - Simplifies LicenseUri and IconUri generation by using
GITHUB_REPOSITORY
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| scripts/main.ps1 | Removed Set-GitHubOutput calls and added GITHUB_REPOSITORY_NAME derivation |
| scripts/helpers/Build/Build-PSModuleManifest.ps1 | Changed URI templates to use GITHUB_REPOSITORY directly |
| action.yml | Replaced uses: PSModule/GitHub-Script with shell: pwsh and run block; updated artifact path |
Comments suppressed due to low confidence (2)
scripts/main.ps1:23
- The
ModuleNameoutput is no longer written to$env:GITHUB_OUTPUTafter removingSet-GitHubOutput. Add a line like"ModuleName=$moduleName" >> $env:GITHUB_OUTPUTto preserve this output.
$sourceFolderPath = Resolve-Path -Path 'src' | Select-Object -ExpandProperty Path
action.yml:47
- Inputs such as
Debug,Prerelease,Verbose,Version, andWorkingDirectoryare no longer passed into the script after removing thewithblock. Ensure these parameters are forwarded (e.g., viaenv:entries or command-line arguments) so the build script retains full configurability.
run: |
…gging in build scripts
…e module build configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes updates to the PowerShell module build process and related scripts, focusing on improving compatibility with GitHub Actions and simplifying output handling. The changes primarily affect the
action.ymlfile and several PowerShell scripts.Updates to GitHub Actions configuration:
action.yml: Replaced theusesdirective for running PowerShell scripts with theshell: pwshoption and updated therunblock to execute the build script directly. Simplified artifact upload by changing the path reference to usesteps.build.outputs.ModuleOutputFolderPathinstead of parsing JSON.Updates to script handling:
scripts/main.ps1: Added a new environment variable$env:GITHUB_REPOSITORY_NAMEderived from$env:GITHUB_REPOSITORYfor repository name extraction. ReplacedSet-GitHubOutputcalls with direct appending to$env:GITHUB_OUTPUTfor compatibility with GitHub Actions. [1] [2]Updates to URI generation:
scripts/helpers/Build/Build-PSModuleManifest.ps1: Simplified the generation ofLicenseUriandIconUriby using$env:GITHUB_REPOSITORYdirectly instead of combining$env:GITHUB_REPOSITORY_OWNERand$env:GITHUB_REPOSITORY_NAME. [1] [2]Type of change
Checklist