🩹 [Patch]: Add URL generation and default formatting for GitHubAppInstallations #443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: MariusStorhaug <17722253+MariusStorhaug@users.noreply.github.com>
GitHubAppInstallations
Copilot finished work on behalf of
MariusStorhaug
June 29, 2025 14:52
…e output type documentation in related functions
There was a problem hiding this comment.
Pull Request Overview
This PR adds URL generation support for GitHubAppInstallation objects and provides default formatting views.
- Introduces a new
Urlproperty and updates constructors inGitHubAppInstallation.ps1to generate profile and installation URLs. - Updates organization and enterprise cmdlets to emit
GitHubAppInstallationand pass a custom hostname. - Adds
GitHubAppInstallation.Format.ps1xmlwith table and list views that hyperlink properties.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/functions/private/Apps/GitHub Apps/Get-GitHubOrganizationAppInstallation.ps1 | Added .OUTPUTS comment documenting the output type. |
| src/functions/private/Apps/GitHub Apps/Get-GitHubEnterpriseOrganizationAppInstallation.ps1 | Added .OUTPUTS and updated the loop to iterate over response data and include hostname in constructor. |
| src/formats/GitHubAppInstallation.Format.ps1xml | Created table and list views for GitHubAppInstallation, including hyperlink formatting. |
| src/classes/public/App/GitHubAppInstallation.ps1 | Added Url property and updated constructors to generate URLs based on target type and hostname. |
Comments suppressed due to low confidence (1)
src/functions/private/Apps/GitHub Apps/Get-GitHubEnterpriseOrganizationAppInstallation.ps1:64
- Changed iteration target from
$.Response.installationsto$.Responsemay break if the API still returns aninstallationsproperty; verify the response schema and update the loop to avoid missing items.
foreach ($installation in $_.Response) {
src/functions/private/Apps/GitHub Apps/Get-GitHubOrganizationAppInstallation.ps1
Show resolved
Hide resolved
|
Module GitHub - 0.32.3 published to the PowerShell Gallery. |
|
GitHub release for GitHub v0.32.3 has been created. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces enhancements to the
GitHubAppInstallationclass, updates related functions to support new features, and adds a new format configuration for displayingGitHubAppInstallationobjects. The changes improve the handling of URLs, streamline object creation, and enhance the output formatting for better usability.GitHubAppInstallations#442Enhancements to
GitHubAppInstallationclass:$Urlproperty to store the profile URL of the target based on its type, and updated the constructor to populate this property usinghtml_urlfrom the API response.$Targetproperty to includeName,Type, andUrl, dynamically constructing the URL based on theHostNameparameter.$Urlproperty to provide a direct link to the installation settings page using theHostName,Type, andTarget.Format configuration for
GitHubAppInstallation:GitHubAppInstallationobjects. The table view includes hyperlinks forIDandTarget.Namewhen supported, and the list view includes all relevant properties such asUrl,Permissions, andEvents.Updates to related functions:
Get-GitHubEnterpriseOrganizationAppInstallationto pass theHostNameparameter when creatingGitHubAppInstallationobjects, and defined the.OUTPUTSsection to specify the output type.Get-GitHubOrganizationAppInstallationto define the.OUTPUTSsection, specifying that the function outputsGitHubAppInstallationobjects.