🪲 [Fix]: Suppress output of functions for revoking access tokens #452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR suppresses the output of token revocation functions by explicitly discarding the return values from Invoke-GitHubAPI.
- Assigns the result of
Invoke-GitHubAPIto$nullin two functions to prevent unintended output. - Ensures consistent handling of unused API call outputs across public and private modules.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/functions/public/Auth/Revoke-GitHubAccessToken.ps1 | Discarded Invoke-GitHubAPI output by assigning it to $null. |
| src/functions/private/Apps/GitHub Apps/Revoke-GitHubAppInstallationAccessToken.ps1 | Discarded Invoke-GitHubAPI output by assigning it to $null. |
Comments suppressed due to low confidence (1)
src/functions/private/Apps/GitHub Apps/Revoke-GitHubAppInstallationAccessToken.ps1:39
- Add a Pester test to verify that this function emits no output when revoking an access token, ensuring the suppression behavior is covered by tests.
$null = Invoke-GitHubAPI @InputObject
|
Module GitHub - 0.33.3 published to the PowerShell Gallery. |
|
GitHub release for GitHub v0.33.3 has been created. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request makes small adjustments to improve code clarity and ensure consistent handling of unused return values. Specifically, it updates two functions to explicitly discard the output of the
Invoke-GitHubAPIcommand by assigning it to$null.Changes to improve code clarity:
src/functions/private/Apps/GitHub Apps/Revoke-GitHubAppInstallationAccessToken.ps1: Updated theRevoke-GitHubAppInstallationAccessTokenfunction to assign the return value ofInvoke-GitHubAPIto$null, ensuring unused output is explicitly discarded.src/functions/public/Auth/Revoke-GitHubAccessToken.ps1: Updated theRevoke-GitHubAccessTokenfunction to assign the return value ofInvoke-GitHubAPIto$null, maintaining consistency in handling unused outputs.Type of change
Checklist