🩹 [Patch]: Sort the return for Get-GitHubContext
#505
Merged
+9
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and enterprise parameters
There was a problem hiding this comment.
Pull Request Overview
This pull request improves the usability and consistency of the GitHub context management PowerShell module by sorting outputs, renaming parameter sets for clarity, and enhancing the context completer functionality.
- Renamed parameter sets from technical names to descriptive ones for better clarity
- Added sorting to context outputs to provide consistent, alphabetical ordering
- Enhanced the context completer to suppress debug output and deduplicate results
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/functions/public/Auth/Context/completers.ps1 | Enhanced context completer to suppress debug output and sort/deduplicate context names |
| src/functions/public/Auth/Context/Get-GitHubContext.ps1 | Renamed parameter sets for clarity and added sorting to context output |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Module GitHub - 0.36.12 published to the PowerShell Gallery. |
|
GitHub release for GitHub v0.36.12 has been created. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request focuses on improving the usability and consistency of the GitHub context management PowerShell module. The main changes include renaming parameter sets and internal logic for clarity, ensuring output is sorted for better user experience, and updating the context completer for more accurate and user-friendly suggestions.
Parameter set and logic improvements:
Get-GitHubContext.ps1for clarity (e.g.,'NamedContext'to'Get a named context','ListAvailableContexts'to'List all available contexts') and updated corresponding internal logic and debug messages for consistency.Output and completion enhancements:
Get-GitHubContext.ps1to provide a more organized and predictable result.completers.ps1from the private to public directory, and updated the context completer to suppress debug output, sort and deduplicate context names, and improve the accuracy of completion suggestions.Type of change
Checklist