🩹 [Patch]: Co-locate EVERYTHING :) #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…date manifest and action references
…ew directory structure
…ctories and add new ones
…yment capabilities
MariusStorhaug
added a commit
that referenced
this pull request
Feb 12, 2025
This reverts commit 3240ab2.
8 tasks
MariusStorhaug
added a commit
that referenced
this pull request
Feb 12, 2025
## Description Why are we rolling back: - Reusable actions will not automatically reference its own local actions. This PR rolls back the following PRs: - Rollback #133 - Rollback #131 ## Type of change <!-- Use the check-boxes [x] on the options that are relevant. --> - [ ] 📖 [Docs] - [ ] 🪲 [Fix] - [x] 🩹 [Patch] - [ ]⚠️ [Security fix] - [ ] 🚀 [Feature] - [ ] 🌟 [Breaking change] ## Checklist <!-- Use the check-boxes [x] on the options that are relevant. --> - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The actions within the PSModule framework are closely interconnected, each serving a critical function. However, developing and testing both individual actions and their integration within the framework has become increasingly inefficient due to their scattered nature. Additionally, issue tracking was fragmented across multiple repositories, making management more cumbersome.
To improve efficiency, I have consolidated everything into a single reusable workflow repository. This centralization simplifies development, testing, and issue tracking, providing a unified view of the entire process.
Motivation
The actions within the PSModule framework are tightly connected, each playing a crucial role. However, developing and testing both individual actions and their integration with the whole has become inefficient due to their scattered nature. Additionally, issue tracking was spread across multiple repositories, further complicating the process.
To streamline development, testing, and issue tracking, I’ve opted to consolidate everything into a single reusable workflow repository. This will provide a unified view of the entire process and improve efficiency.
Documentation
Moving forward, the documentation for the PSModule framework will be hosted on GitHub Pages using Material for MkDocs. As a result, the README in this workflow repository will be minimal, serving primarily as a pointer to the official documentation.
What has moved where
Testing
All testing workflows have been consolidated into this repository to ensure that both individual actions and the overall workflow are tested as changes are developed. This improves cycle time and enhances confidence in the stability of changes before they are released.
Type of change
Checklist
Here’s an improved version with clearer wording, better structure, and more fluid readability: