Skip to content

🩹 [Patch]: Add condition to make nightly run work fine #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

MariusStorhaug
Copy link
Member

Description

  • Add condition to make nightly run work fine

Type of change

  • 📖 [Docs]
  • 🪲 [Fix]
  • 🩹 [Patch]
  • ⚠️ [Security fix]
  • 🚀 [Feature]
  • 🌟 [Breaking change]

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@MariusStorhaug MariusStorhaug requested a review from a team as a code owner August 8, 2024 18:09
@MariusStorhaug MariusStorhaug merged commit 684068e into main Aug 8, 2024
7 checks passed
@MariusStorhaug MariusStorhaug deleted the conditionForNightlly branch August 8, 2024 19:23
MariusStorhaug added a commit that referenced this pull request Nov 18, 2024
## Description

- Reestablish functionality to run `Publish-PSModule` during PR. Used to
create prereleases of a module before it is published with a release
version.
- Revert: #37. This should have been reverted in the following PR,
seeing as it was for nightly runs/adhoc runs. The `CI.yml` template was
added just after which rendered this change unnecessary.
- It still remains to find a way to perserve the functionality, but not
need a pipeline to do it. I.e. a prereleaser "chat" bot that takes
commands from maintainers in the comments of the PR.

## Type of change

<!-- Use the check-boxes [x] on the options that are relevant. -->

- [ ] 📖 [Docs]
- [x] 🪲 [Fix]
- [ ] 🩹 [Patch]
- [ ] ⚠️ [Security fix]
- [ ] 🚀 [Feature]
- [ ] 🌟 [Breaking change]

## Checklist

<!-- Use the check-boxes [x] on the options that are relevant. -->

- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant