Skip to content

🩹 [Patch]: Remove initialization step and dependency on Utilities #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 1, 2025

Conversation

MariusStorhaug
Copy link
Member

@MariusStorhaug MariusStorhaug commented Jun 1, 2025

Description

Remove the initialization step and dependency on Utilities, the Install-PSModuleHelpers takes over.

Type of change

  • 📖 [Docs]
  • 🪲 [Fix]
  • 🩹 [Patch]
  • ⚠️ [Security fix]
  • 🚀 [Feature]
  • 🌟 [Breaking change]

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@Copilot Copilot AI review requested due to automatic review settings June 1, 2025 22:07
@MariusStorhaug MariusStorhaug requested a review from a team as a code owner June 1, 2025 22:07
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This patch removes the manual initialization step and the hard dependency on the Utilities module from the PowerShell publish script and associated workflow.

  • Dropped the #Requires directive for Utilities and related modules in Publish-PSModule.ps1
  • Removed the “Initialize environment” step from the GitHub Actions workflow

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
scripts/helpers/Publish-PSModule.ps1 Removed #Requires -Modules Utilities,… directive
.github/workflows/Action-Test.yml Omitted the environment initialization step
Comments suppressed due to low confidence (2)

scripts/helpers/Publish-PSModule.ps1:13

  • Removing the #Requires directive skips built-in dependency validation. Consider documenting or ensuring dependencies are loaded via Import-Module or a manifest to maintain clarity and fail-fast behavior.
#Requires -Modules Utilities, PowerShellGet, Microsoft.PowerShell.PSResourceGet, GitHub, PSSemVer

.github/workflows/Action-Test.yml:26

  • Dropping the environment initialization step may lead to inconsistent test runs. Ensure any required setup (module paths, credentials) is handled elsewhere or add comments explaining where initialization occurs now.
-      - name: Initialize environment

@MariusStorhaug MariusStorhaug self-assigned this Jun 1, 2025
@MariusStorhaug MariusStorhaug merged commit caa0ab1 into main Jun 1, 2025
13 checks passed
@MariusStorhaug MariusStorhaug deleted the removeInit branch June 1, 2025 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant