Skip to content

🩹 [Patch]: Check for proc count #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 13, 2024
Merged

🩹 [Patch]: Check for proc count #50

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3adab39
use [System.Environment]::ProcessorCount instead of $env:NUMBER_OF_PR…
MariusStorhaug Apr 13, 2024
46bf4f8
Add a test
MariusStorhaug Apr 13, 2024
8d5833c
test
MariusStorhaug Apr 13, 2024
09e79ef
test
MariusStorhaug Apr 13, 2024
646dbc2
FIx
MariusStorhaug Apr 13, 2024
49606ab
Refactor New-PSModuleTest function to remove unused code
MariusStorhaug Apr 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test
  • Loading branch information
@MariusStorhaug
MariusStorhaug committed Apr 13, 2024
commit 8d5833c5162f529caa6523f9927419541e02bed1
4 changes: 3 additions & 1 deletion scripts/tests/PSModule/SourceCode.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,9 @@ Describe 'PSModule - SourceCode tests' {
$scriptFiles | ForEach-Object {
$fileContent = Get-Content -Path $_.FullName -Raw
if ($fileContent -match '\$env:NUMBER_OF_PROCESSORS') {
$issues += " - $($_.FullName): Use [System.Environment]::ProcessorCount instead of $env:NUMBER_OF_PROCESSORS"
$issues += " - $($_.FullName)"
#Get linenumber of the match
Write-Verbose ($matches | Out-String) -Verbose
}
}
$issues -join [Environment]::NewLine |
Expand Down