RuntimeTimer for the toolkit #7913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZHUI
reviewed
Jan 29, 2024
| @@ -304,6 +304,7 @@ def __init__( | |||
| if not args.skip_profile_timer: | |||
| set_timers() | |||
| self.timers = get_timers() | |||
| self.runtime_timer = RuntimeTimer("RuntimeTimer") | |||
There was a problem hiding this comment.
日志量较少，不进行开关控制了。
这个是默认开的吗？是如何控制开关？
gongel
reviewed
Jan 29, 2024
paddlenlp/trainer/plugins/timer.py
Outdated
| if self.timer.started_ is True: | ||
| self.timer.stop() | ||
| self.timer.reset() | ||
| else: |
gongel
reviewed
Jan 29, 2024
| @@ -718,6 +723,8 @@ def train( | |||
| self.create_optimizer_and_scheduler(num_training_steps=max_steps) | |||
| self._load_optimizer_and_scheduler(resume_from_checkpoint) | |||
|
|
|||
| logger.info(f"{self.runtime_timer.log()}") | |||
There was a problem hiding this comment.
能否通过开关控制下
日志量较少，不进行开关控制了。
KB-Ding
added a commit
to KB-Ding/PaddleNLP
that referenced
this pull request
Jan 29, 2024
* RuntimeTimer for the toolekit * RuntimeTimer for the toolekit * reformat * fix timer and load checkpoints * remove reset
wawltor
pushed a commit
that referenced
this pull request
Jan 29, 2024
KB-Ding
added a commit
to KB-Ding/PaddleNLP
that referenced
this pull request
Jan 31, 2024
* RuntimeTimer for the toolekit * RuntimeTimer for the toolekit * reformat * fix timer and load checkpoints * remove reset
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
APIs
Description
RuntimeTimer for the toolkit
checkpoint 加载计时：
checkpoint 存储计时：
