Support for nativescript 5 and 6 #60
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ccepts import with absolute path. An error occurred while executing the command tns run ios --bundle --env.uglify --env.aot --env.report: ERROR in node_modules / nativescript-grid-view / grid-view.d.ts (17,71): error TS2307: Can not find module 'ui / core / view'. node_modules / nativescript-grid-view / grid-view.d.ts (18,64): error TS2307: Can not find module 'ui / list-view'. node_modules / nativescript-grid-view / grid-view.d.ts (19,27): error TS2307: Can not find module 'data / observable'. node_modules / nativescript-grid-view / angular / grid-view-comp.d.ts (20,14): error TS2416: Property 'nativeElement' in type 'GridViewComponent' is not assignable to the same property in base type 'TemplatedItemsComponent' . Property 'off' is missing in type 'GridView' but required in type 'TemplatedItemsView'. (21,15): error TS2416: Property 'templatedItemsView' in type 'GridViewComponent' is not assignable to the same property in base type 'TemplatedItemsComponent' . Type 'GridView' is not assignable to type 'TemplatedItemsView'. Fixed imports with absolute path so that the plugin is compatible with the new version of Nativescript 5 and 6.
|
I'm well aware that the {N} core team is depreciating those short import paths and are pushing all devs to write the full. But this seems ridiculous as you have to type an additional 31 symbols for every import. You can read more details on the discussion/suggestions here: NativeScript/NativeScript#4041. For all of my plugins I'm not going to fix the short imports until the core team implements a better solution for this. So I urge you to 👍 and comment on the above mentioned issue. Short import paths continue to work w/o any problem if you use the correct paths in the tsconfig file: NativeScript-Grid-View/demo-ng/tsconfig.json Lines 15 to 23 in acd4365 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nativescript 5.4.0 is not accepting import with relative path, only accepts import with absolute path.
An error occurred while executing the command tns run ios --bundle --env.uglify --env.aot --env.report:
Fixed imports with absolute path so that the plugin is compatible with the new version of Nativescript 5 and 6.