Migrate MacOS Signing to OneBranch #25295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
TravisEz13
approved these changes
Apr 9, 2025
|
📣 Hey @@jshigetomi, how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗 https://aka.ms/PSRepoFeedback |
pwshBot
pushed a commit
to pwshBot/PowerShell
that referenced
this pull request
Apr 10, 2025
Co-authored-by: Justin Chung <chungjustin@microsoft.com>
9 tasks
pwshBot
pushed a commit
to pwshBot/PowerShell
that referenced
this pull request
Apr 21, 2025
Co-authored-by: Justin Chung <chungjustin@microsoft.com>
9 tasks
Sysoiev-Yurii
pushed a commit
to Sysoiev-Yurii/PowerShell
that referenced
this pull request
May 12, 2025
Co-authored-by: Justin Chung <chungjustin@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This pull request includes changes to the
.pipelines/templates/mac-package-build.ymlfile, primarily focusing on updating the code signing task and improving the handling of environment variables.Updates to Code Signing Task:
SFP.build-tasks.custom-build-task-1.EsrpCodeSigning@5task withonebranch.pipeline.signing@1for the code signing process. This includes updating the task display name and input parameters to streamline the signing operation.Improvements to Environment Variable Handling:
Expand-ArchiveandNew-Itemcommands to use$(variable)instead of$env:variablefor consistency and better readability.PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright header