Skip to content

Retry ClearlyDefined operations #25385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 17, 2025
Merged

Retry ClearlyDefined operations #25385

merged 2 commits into from
Apr 17, 2025

Conversation

TravisEz13
Copy link
Member

@TravisEz13 TravisEz13 commented Apr 17, 2025 •
edited
Loading

PR Summary

This pull request enhances the robustness of API calls in the ClearlyDefined.psm1 module by adding retry logic to handle transient failures. The changes ensure that both harvesting and data retrieval operations can automatically retry failed requests up to five times with a 60-second interval between retries.

Enhancements to API call reliability:

  • Start-ClearlyDefinedHarvest function: Added -MaximumRetryCount 5 and -RetryIntervalSec 60 parameters to the Invoke-WebRequest call, enabling retry logic for harvesting operations.
  • Get-ClearlyDefinedData function: Added -MaximumRetryCount 5 and -RetryIntervalSec 60 parameters to the Invoke-RestMethod call, ensuring retry logic is applied during data retrieval.

PR Context

PR Checklist

@TravisEz13 TravisEz13 marked this pull request as ready for review April 17, 2025 21:44
@TravisEz13 TravisEz13 requested a review from a team as a code owner April 17, 2025 21:44
@TravisEz13
Copy link
Member Author

/azp run PowerShell-CI-linux-packaging, PowerShell-Windows-Packaging-CI

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@TravisEz13 TravisEz13 added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Apr 17, 2025
@TravisEz13 TravisEz13 requested a review from Copilot April 17, 2025 21:46
Copilot
Copilot AI reviewed Apr 17, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • tools/clearlyDefined/src/ClearlyDefined/ClearlyDefined.psm1: Language not supported

@jshigetomi jshigetomi merged commit 2502cc8 into master Apr 17, 2025
35 of 44 checks passed
@TravisEz13 TravisEz13 deleted the TravisEz13-clearlydefined branch April 17, 2025 21:58
@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link
Contributor

microsoft-github-policy-service bot commented Apr 17, 2025 •
edited by unfurl-links bot
Loading

📣 Hey @@TravisEz13, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://aka.ms/PSRepoFeedback

pwshBot pushed a commit to pwshBot/PowerShell that referenced this pull request Apr 17, 2025
@TravisEz13 @pwshBot
Retry ClearlyDefined operations (PowerShell#25385)
1c69f90
@pwshBot pwshBot mentioned this pull request Apr 17, 2025
Merged
9 tasks
Sysoiev-Yurii pushed a commit to Sysoiev-Yurii/PowerShell that referenced this pull request May 12, 2025
@TravisEz13 @Sysoiev-Yurii
Retry ClearlyDefined operations (PowerShell#25385)
974e144
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@jshigetomi jshigetomi jshigetomi approved these changes

Assignees
No one assigned
Labels
CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TravisEz13 @jshigetomi