Skip to content

Update APIScan to use new symbols server #25388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 21, 2025

Conversation

TravisEz13
Copy link
Member

@TravisEz13 TravisEz13 commented Apr 17, 2025

…able groups

PR Summary

This pull request introduces updates to pipeline configuration files and a PowerShell script. The changes primarily focus on improving symbol handling, runtime management, and ensuring smoother development workflows. Below is a breakdown of the most significant changes:

Pipeline Configuration Updates

  • Symbol Server Integration: Added a symbolsFolder parameter to the .pipelines/apiscan-gen-notice.yml file to specify the location of symbols for scanning, enhancing symbol handling during pipeline execution.
  • Comment Cleanup: Removed outdated comments related to PAT permissions and symbol handling from .pipelines/templates/compliance/apiscan.yml, simplifying the configuration.

Runtime Management

  • Unused Runtime Cleanup: Added a PowerShell script step in .pipelines/templates/compliance/apiscan.yml to remove unused runtimes and temporarily exclude problematic runtimes (win-x86), optimizing build artifacts.

Development Workflow Improvement

  • Git Ignore for NuGet Config: Updated the New-NugetConfigFile function in build.psm1 to mark the nuget.config file as skipped by Git, preventing unnecessary changes from being tracked.

PR Context

PR Checklist

@TravisEz13 TravisEz13 changed the title Refactor API scan pipeline to improve symbol handling and update variable groups Update APIScan to use new symbols server Apr 19, 2025
@TravisEz13 TravisEz13 added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Apr 19, 2025
@TravisEz13
Copy link
Member Author

/azp run PowerShell-CI-linux-packaging, PowerShell-Windows-Packaging-CI

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@TravisEz13 TravisEz13 marked this pull request as ready for review April 21, 2025 20:13
@TravisEz13 TravisEz13 requested review from jshigetomi and a team as code owners April 21, 2025 20:13
@TravisEz13 TravisEz13 merged commit 12a6500 into PowerShell:master Apr 21, 2025
48 of 51 checks passed
Copy link
Contributor

microsoft-github-policy-service bot commented Apr 21, 2025

📣 Hey @@TravisEz13, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://aka.ms/PSRepoFeedback

pwshBot pushed a commit to pwshBot/PowerShell that referenced this pull request Apr 21, 2025
pwshBot pushed a commit to pwshBot/PowerShell that referenced this pull request Apr 21, 2025
Sysoiev-Yurii pushed a commit to Sysoiev-Yurii/PowerShell that referenced this pull request May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants