Skip to content

Remove OnDeserialized and Serializable attributes from Microsoft.Management.UI.Internal project #25548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 2, 2025

Conversation

daxian-dbw
Copy link
Member

@daxian-dbw daxian-dbw commented May 13, 2025

PR Summary

This PR is a follow-up of the #25497, to clean up the [Serializable] and [OnDeserialized] attributes, as well as the EnableUnsafeBinaryFormatterSerialization property from powershell-win-core.csproj (to disable the use of BinaryFormatter).

PR Checklist

@daxian-dbw daxian-dbw requested review from jshigetomi and a team as code owners May 13, 2025 05:20
@daxian-dbw daxian-dbw added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label May 13, 2025
@iSazonov
Copy link
Collaborator

@daxian-dbw There are three [field: NonSerialized].

@daxian-dbw daxian-dbw requested a review from TravisEz13 May 13, 2025 19:52
@microsoft-github-policy-service microsoft-github-policy-service bot added the Review - Needed The PR is being reviewed label May 21, 2025
Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@daxian-dbw daxian-dbw merged commit 625da6f into PowerShell:master Jun 2, 2025
48 of 52 checks passed
@daxian-dbw daxian-dbw deleted the cleanup branch June 2, 2025 22:16
@daxian-dbw daxian-dbw removed the Review - Needed The PR is being reviewed label Jun 2, 2025
Copy link
Contributor

microsoft-github-policy-service bot commented Jun 2, 2025

📣 Hey @@daxian-dbw, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://aka.ms/PSRepoFeedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log
Projects
Development

Successfully merging this pull request may close these issues.

3 participants