Skip to content

Permission for publication of PyMySQL stubs in typeshed #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jhagerer opened this issue Oct 26, 2016 · 2 comments
Closed

Permission for publication of PyMySQL stubs in typeshed #524

jhagerer opened this issue Oct 26, 2016 · 2 comments

Comments

@jhagerer
Copy link

jhagerer commented Oct 26, 2016 •
edited
Loading

I started to generate stubs for PyMySQL, which I uploaded to this repo.

I want to commit all this as third party stubs to the typeshed repo as I stated it in an issue there. According to the guidelines of typeshed and PEP484 respectively, the official permission from the regarding project for which the stubs are generated is necessary.

So, does the PyMySQL project agree that stubs generated for this project are published as third party stubs as part of the typeshed project?

Thanks in advance!
@methane
Copy link
Member

methane commented Oct 26, 2016

Thanks, go ahead!

One point:
https://github.com/ghagerer/pymysql_stubs/blob/master/__init__.pyi#L30-L33

def Connect(*args, **kwargs) -> Connection: ...
def get_client_info() -> str: ...

connect = ...  # type: Any

connect should be defined as function which signature is same to Connect.
Connect is only for backward compatibility. connect is standard (defined in DB-API 2.0) API.

@jhagerer
Copy link
Author

jhagerer commented Oct 26, 2016 •
edited
Loading

Thanks! I included your feedback in the code.

@jhagerer jhagerer mentioned this issue Oct 26, 2016
Closed
@methane methane closed this as completed Jan 12, 2017
@darxriggs darxriggs mentioned this issue Jan 23, 2021
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@methane @jhagerer