-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Introduce types (replace stubs in typeshed) #953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I still don't like it. I am waiting to minimum supported version become Python 3.10. See python/cpython#23316 Or at least Python 3.7; we can use
Why it's easy? DB-API is very stable. And other APIs are not important for end-users. |
You can have type hints without Also, I don't see what that pull request has to do with type hints in pymysql. It appears to change something much lower-level than a Python library needs to care about. |
It increase memory usage and time for import. |
Python caches modules, so if pymysql uses We are talking about approximately 5% more time, assuming no other libraries used than PyMySQL, or about 2% if you use PyMySQL and requests, for example. On my system:
I don't know of a good way to measure memory usage, so I didn't check that. |
Now that Python 3.6 is the minimum required Python version, it would be a good idea to maintain the types that are currently maintained in typeshed (see #524) directly in this library. Otherwise they easily get out of sync which is already the current state unfortunately.
The text was updated successfully, but these errors were encountered: