Skip to content

Call to non-existent function #981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Laranto opened this issue Apr 22, 2021 · 2 comments · Fixed by #1003
Closed

Call to non-existent function #981

Laranto opened this issue Apr 22, 2021 · 2 comments · Fixed by #1003

Comments

@Laranto
Copy link

Laranto commented Apr 22, 2021

In the legacy handshake there is still a call to _auth.scramble_old_password
https://github.com/PyMySQL/PyMySQL/blob/master/pymysql/connections.py#L924

This function was deleted in this commit
cd61e56
@edthedev
Copy link

Since the commit references a CVE known vulnerability, I imagine the functionality is not coming back.

Can anyone tell me if I am correct in assuming that the only reason the code would hit this obsolete function call is if newer methods already failed?

Is it safe to assume that this function should be replaced with an exception that asks the user to upgrade the MySQL instance they are connecting to? Or is the situation more nuanced?

@ddriddle
Copy link

ddriddle commented Jun 3, 2021

I suggest a better error message be included something similar to what mysql-connector-python throws:

mysql.connector.errors.NotSupportedError: Authentication with old (insecure) passwords is not supported. For more information, lookup Password Hashing in the latest MySQL manual

@methane methane mentioned this issue Aug 28, 2021
Closed
methane added a commit to methane/PyMySQL that referenced this issue Aug 28, 2021
@methane
Fix calling undefined function
2f6c3d0 
Fixes PyMySQL#981.
@methane methane mentioned this issue Aug 28, 2021
Merged
methane added a commit that referenced this issue Aug 28, 2021
@methane
Fix calling undefined function (#1003)
33d165d 
Fixes #981.
This was referenced Sep 7, 2021
Closed
Closed
@sarah-witt sarah-witt mentioned this issue Jul 27, 2022
Merged
4 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix calling undefined function methane/PyMySQL
3 participants
@Laranto @edthedev @ddriddle