Skip to content

update pymysql.constants.CR #1029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 1, 2022
Merged

update pymysql.constants.CR #1029

merged 1 commit into from
Feb 1, 2022

Conversation

Nothing4You
Copy link
Contributor

values from https://github.com/mysql/mysql-server/blob/mysql-8.0.28/include/errmsg.h

I noticed that #341 included CR.CR_UNUSED_1, but it was named CR.CR_SECURE_AUTH instead.
is that intentional?

@methane
Copy link
Member

methane commented Feb 1, 2022

I noticed that #341 included CR.CR_UNUSED_1, but it was named CR.CR_SECURE_AUTH instead.
is that intentional?

See this comment. #341 (comment)

It was CR_UNUSED_1 when I generated the CR.py

@methane methane merged commit 2beebd9 into PyMySQL:main Feb 1, 2022
@Nothing4You
Copy link
Contributor Author

It was CR_UNUSED_1 when I generated the CR.py

It was and is CR_UNUSED_1 in MySQL's errmsg.h but it was imported as CR_SECURE_AUTH, therefore not matching the name in errmsg.h.

@Nothing4You Nothing4You deleted the add-new-cr-constants branch February 1, 2022 00:10
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nothing4You @methane