Skip to content

Resolve UTF8 charset case-insensitively #1195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 12, 2025
Merged

Resolve UTF8 charset case-insensitively #1195

merged 3 commits into from
Jan 12, 2025

Conversation

ek247
Copy link
Contributor

@ek247 ek247 commented Jan 10, 2025

Current behavior:

>>> from pymysql.charset import charset_by_name
>>> print(charset_by_name('UTF8'))
None
>>> print(charset_by_name('utf8'))
Charset(id=45, name='utf8mb4', collation='utf8mb4_general_ci')
>>> print(charset_by_name('latin1'))
Charset(id=8, name='latin1', collation='latin1_swedish_ci')
>>> print(charset_by_name('LATIN1'))
Charset(id=8, name='latin1', collation='latin1_swedish_ci')

where I think it's supposed to be able to case-insensitively resolve any utf8 string into utf8mb4

@methane methane merged commit 7dead51 into PyMySQL:main Jan 12, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ek247 @methane