Skip to content

use KILL instead of COM_KILL for MySQL 8.4 support #1197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 14, 2025

Conversation

methane
Copy link
Member

@methane methane commented Jan 14, 2025

No description provided.

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 86.42%. Comparing base (1e28be8) to head (846d678).
Report is 28 commits behind head on main.

Files with missing lines Patch % Lines
pymysql/connections.py 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1197      +/-   ##
==========================================
+ Coverage   86.24%   86.42%   +0.17%     
==========================================
  Files          17       17              
  Lines        2436     2424      -12     
  Branches      258      254       -4     
==========================================
- Hits         2101     2095       -6     
+ Misses        249      245       -4     
+ Partials       86       84       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@methane methane merged commit 0d4609c into PyMySQL:main Jan 14, 2025
23 of 26 checks passed
@methane methane deleted the stop-using-kill branch January 14, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant