Skip to content

added more character sets though 303 #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

added more character sets though 303 #577

wants to merge 1 commit into from

Conversation

jwoos
Copy link

@jwoos jwoos commented Jun 6, 2017

No description provided.

@rmn36
Copy link

rmn36 commented Jun 20, 2017

Can someone please merge this? I am currently facing an issue that is being caused by this. It is a simple fix.

@methane
Copy link
Member

methane commented Jun 20, 2017

I can't confirm them.
Additionally, collation id is 1byte in wire protocol. So PyMySQL can't support collations over 256.

You should start utf8mb4 and use init_command="SET NAMES utf8mb4 COLLATE <collation you want to use> instead.

@methane
Copy link
Member

methane commented Jun 20, 2017

MySQL 5.7.18:

...
| 246 | utf8mb4            | utf8mb4_unicode_520_ci   |            |
| 247 | utf8mb4            | utf8mb4_vietnamese_ci    |            |
| 248 | gb18030            | gb18030_chinese_ci       | Yes        |
| 249 | gb18030            | gb18030_bin              |            |
| 250 | gb18030            | gb18030_unicode_520_ci   |            |
+-----+--------------------+--------------------------+------------+
222 rows in set (0.00 sec)

I don't know which version of MySQL (or MariaDB) do you use. But they are not portable.
Use portable collation at connection phase.

@jwoos
Copy link
Author

jwoos commented Jun 20, 2017

Going to close this, I pulled the wrong docker image version (8) when I was working with this

@jwoos jwoos closed this Jun 20, 2017
@methane
Copy link
Member

methane commented Jun 20, 2017

Even if MySQL 8 is released, PyMySQL can't use collations which id > 255.

@jwoos
Copy link
Author

jwoos commented Jun 20, 2017

Those were the character sets that I got by running the commands that were specified

@meeuw meeuw mentioned this pull request Oct 3, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants