Skip to content

Remove context manager #763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 19, 2018
Merged

Remove context manager #763

merged 2 commits into from
Dec 19, 2018

Conversation

methane
Copy link
Member

@methane methane commented Dec 18, 2018

No description provided.

@methane methane merged commit e06bbac into PyMySQL:master Dec 19, 2018
@methane methane deleted the remove-context-manager branch December 19, 2018 08:45
@aisbergg aisbergg mentioned this pull request Feb 4, 2019
Merged
@ulidtko
Copy link

ulidtko commented Apr 24, 2020

Woah, what an ample deprecation period! Whopping 7 weeks since #742.

(stops wondering why our PyMySQL 0.8.0 doesn't provide context manager for Connection)

@methane
Copy link
Member Author

methane commented Apr 25, 2020

PyMySQL 0.9.3 released at 2018-12-18.
So the deprecation period is more than 1 year.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@methane @ulidtko