Skip to content

Optimize packet reading #779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 5, 2019
Merged

Optimize packet reading #779

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
92e7855
Optimized packet reading speed
Deneby67 Feb 4, 2019
be94738
Fixed remarks
Deneby67 Feb 5, 2019
f6ba07f
Fixed remarks
Deneby67 Feb 5, 2019
2edc204
Fixed test crash
Deneby67 Feb 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pymysql/connections.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -638,7 +638,7 @@ def _read_packet(self, packet_type=MysqlPacket):
:raise OperationalError: If the connection to the MySQL server is lost.
:raise InternalError: If the packet sequence number is wrong.
"""
buff = b''
buff = bytearray()
while True:
packet_header = self._read_bytes(4)
#if DEBUG: dump_packet(packet_header)
Expand Down Expand Up @@ -666,7 +666,7 @@ def _read_packet(self, packet_type=MysqlPacket):
if bytes_to_read < MAX_PACKET_LEN:
break

packet = packet_type(buff, self.encoding)
packet = packet_type(bytes(buff), self.encoding)
packet.check_error()
return packet

Expand Down