Skip to content

Add context manager to Connection. #886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 2, 2021
Merged

Add context manager to Connection. #886

merged 1 commit into from
Jan 2, 2021

Conversation

cmauro1
Copy link
Contributor

@cmauro1 cmauro1 commented Aug 17, 2020 •
edited by methane
Loading

Fixes #735.

@cmauro1
Update connections.py
5857c1f 
Added __enter__ and __exit__ methods (lines 329 - 334) to allow for with statement
@j08lue
Copy link

j08lue commented Sep 9, 2020

Why was the context manager functionality removed in the first place? Would you prefer a different way to use contexts with connection objects?

@methane
Copy link
Member

methane commented Sep 9, 2020

See #735.

@methane methane changed the title Update connections.py Add context manager to Connection. Sep 9, 2020
@methane
Copy link
Member

methane commented Sep 9, 2020

I will merge this before releasing 1.0.
But current master branch is for 0.10.

@j08lue j08lue mentioned this pull request Sep 9, 2020
Closed
@j08lue
Copy link

j08lue commented Sep 9, 2020

I see, thank you.

@methane methane merged commit 4e481fa into PyMySQL:master Jan 2, 2021
@methane methane mentioned this pull request Jan 6, 2021
Closed
@dashmug dashmug mentioned this pull request Jan 15, 2021
Closed
@j08lue j08lue mentioned this pull request Feb 25, 2021
Merged
3 tasks
@dependabot dependabot bot mentioned this pull request Mar 12, 2021
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

With + Connection - returns cursor rather than the connection, doesn't close connection on exit
3 participants
@cmauro1 @j08lue @methane