fix test unix_socket for MariaDB-10.4 #907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MariaDB-10.4+ has unix_socket plugin compiled in. Server version: 10.4.18-MariaDB Source distribution Copyright (c) 2000, 2018, Oracle, MariaDB Corporation Ab and others. Type 'help;' or '\h' for help. Type '\c' to clear the current input statement. MariaDB [(none)]> show plugins; +-------------------------------+----------+--------------------+---------+---------+ | Name | Status | Type | Library | License | +-------------------------------+----------+--------------------+---------+---------+ ... | unix_socket | ACTIVE | AUTHENTICATION | NULL | GPL | ..
MariaDB 10.0 and 10.1 are out of support. Replace these with current MariaDB GA versions. Keep MariaDB 5.5 so minimium compatibility is maintained.
|
cryptography version bumped from 3.2.1 (https://travis-ci.com/github/PyMySQL/PyMySQL/jobs/456258876#L219) to 3.3 (https://travis-ci.com/github/PyMySQL/PyMySQL/jobs/456406912#L212) and failed. |
crypography-3.3 fails to compile against openssl-1.0.2 in xenial. Bump travis to bionic to avoid the compile failure. Ref: pyca/cryptography#5612
|
Thank you @methane |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unix_socket is inbuilt in MariaDB-10.4+.
MariaDB-10.0 and 10.1 are out of support so replace these with MariaDB supported versions.
Like MySQL-5.5 keep MariaDB-5.5 as an oldest working version.