Skip to content

Use keyword only argument #930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 5, 2021
Merged

Use keyword only argument #930

merged 2 commits into from
Jan 5, 2021

Conversation

methane
Copy link
Member

@methane methane commented Jan 5, 2021

No description provided.

@methane methane enabled auto-merge (squash) January 5, 2021 05:39
@methane methane merged commit 511b6a2 into PyMySQL:master Jan 5, 2021
@iamgd67
Copy link

iamgd67 commented Jan 8, 2021

wondering why change connect host arg oder, while this will break all code not using keyword but postion arguments.

@methane
Copy link
Member Author

methane commented Jan 8, 2021

Oh, that's my fault. I should made all arguments keyword-only.

@iamgd67
Copy link

iamgd67 commented Jan 8, 2021

don't really understand what you mean by "all arguments keyword-only", I think lattest code still can pass position arguments by connect('localhost','user','pass')

@methane
Copy link
Member Author

methane commented Jan 8, 2021

don't really understand what you mean by "all arguments keyword-only", I think lattest code still can pass position arguments by connect('localhost','user','pass')

Yes, and it's my fault. I had to forbid it when changing arguments order.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants