-
Notifications
You must be signed in to change notification settings - Fork 443
Comparing changes
Open a pull request
base repository: PyMySQL/mysqlclient
base: e54e861
head repository: SpamExperts/mysqlclient-python
compare: 426342a
- 8 commits
- 1 file changed
- 2 contributors
Commits on Oct 27, 2016
-
Configuration menu - View commit details
-
Copy full SHA for d30d54c - Browse repository at this point
Copy the full SHA d30d54cView commit details -
Load SSL options from the environment.
- Remove the previous generic option loading, which wouldn't work for SSL (because we need a dictionary) and that was all we really cared about. - Load the various SSL options from the environment if they are present and not in the arguments. - Skip this for any localhost connection because TLS doesn't make sense there.
Configuration menu - View commit details
-
Copy full SHA for b86c0d2 - Browse repository at this point
Copy the full SHA b86c0d2View commit details -
Provide the ability to explicitly say no-ssl.
If ssl is not missing but =None, then do not do the environment load. The currently behaviour has ssl=None fail when it tries to make a TLS connection, so this shouldn't break anything, and allows the system to be bypassed when needed.
Configuration menu - View commit details
-
Copy full SHA for 0034180 - Browse repository at this point
Copy the full SHA 0034180View commit details -
Always skip SSL if host=localhost.
If we are making a connection to localhost, then passing anything for SSL will always mean a failed connection, because a certificate cannot be verified (if TCP/IP) or SSL doesn't make sense (if UNIX). Make it easier to call connect with ssl values by always ignoring them in the localhost case. This means that callers do not need to check if the host is localhost and can simply always provide an SSL value (e.g. if the host is a variable).
Configuration menu - View commit details
-
Copy full SHA for 88b50c1 - Browse repository at this point
Copy the full SHA 88b50c1View commit details -
Configuration menu - View commit details
-
Copy full SHA for fddbc19 - Browse repository at this point
Copy the full SHA fddbc19View commit details
Commits on Oct 28, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 55a47bb - Browse repository at this point
Copy the full SHA 55a47bbView commit details
Commits on May 14, 2020
-
Merge branch 'master' of https://github.com/PyMySQL/mysqlclient-python …
…into MMA-3573
Silviu Surcica committedMay 14, 2020 Configuration menu - View commit details
-
Copy full SHA for d8890cf - Browse repository at this point
Copy the full SHA d8890cfView commit details
Commits on May 15, 2020
-
Merge pull request #2 from SpamExperts/MMA-3573
MMA-3573. Update from upstream
silviu.surcica authoredMay 15, 2020 Configuration menu - View commit details
-
Copy full SHA for 426342a - Browse repository at this point
Copy the full SHA 426342aView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff e54e861...426342a