Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: PyMySQL/mysqlclient
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: e54e861
Choose a base ref
...
head repository: Tauwasser/mysqlclient-python
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: e9175a8
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Oct 1, 2017

  1. _mysql: fix row_tell and row_seek functions 

    Previous code wrongly assumed that result data was backed by a contiguous array of rows, which is
not the case (at least from MySQL Connector C 6.1.11 on).
Pointers returned/consumed by mysql_row_tell/mysql_row_seek are now encapsulated as PyCapsules when
passed to Python. Documentation now reflects that arguments and return values are not row numbers.

Tested on Windows 7 x64 with MySQL 5.7, MySQL Connector C 6.1.11 and Python 2.7.14 x32.

Signed-off-by: Robert Abel <rabel@robertabel.eu>
    @Tauwasser
    Tauwasser committed Oct 1, 2017
    Configuration menu
    Copy the full SHA
    e9175a8 View commit details
    Browse the repository at this point in the history
Loading