Skip to content

Add Context Manager Interface to Connection. #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 29, 2019
Merged

Add Context Manager Interface to Connection. #413

merged 2 commits into from
Nov 29, 2019

Conversation

methane
Copy link
Member

@methane methane commented Nov 29, 2019

Fixes #400.

@codecov
Copy link

codecov bot commented Nov 29, 2019

Codecov Report

Merging #413 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #413      +/-   ##
=========================================
+ Coverage   86.61%   86.7%   +0.09%     
=========================================
  Files          12      12              
  Lines        1531    1534       +3     
=========================================
+ Hits         1326    1330       +4     
+ Misses        205     204       -1
Impacted Files Coverage Δ
MySQLdb/connections.py 81.25% <100%> (+1.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fd628e...81fdf9a. Read the comment docs.

@methane methane merged commit 6432209 into PyMySQL:master Nov 29, 2019
@methane methane deleted the context-manager branch November 29, 2019 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add context manager to Connection
1 participant