GitHub Actions workflow updated and caching fixed, Revert back to MariaDB Connector C 3.1.9 #455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #455 +/- ##
=======================================
Coverage 86.66% 86.66%
=======================================
Files 12 12
Lines 1530 1530
=======================================
Hits 1326 1326
Misses 204 204 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated build workflow to work with branches, as well - which is of course helpful for development and debugging.
Fixed the cache key to make use of the CONNECTOR_VERSION environment variable. Previously it used 'mariadb-connector-${CONNECTOR_VERSION}-win' literally, as the variable was never substituted.
Reverted back to connector 3.1.9, as newer versions result in link error. This was previously undiscovered due to the cache key issue.