Do not include timezone if DateTimeKind is Unspecified #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DECREF'ing datetime timezone argument when DateTimeKind is Unspecified was causing `Fatal Python error: deallocating None` because the object was set to `Runtime.PyNone`. Fixed the input to datetime constructor as we were passing milliseconds, where it should be microseconds.
ef08a75 to
bec9563
Compare
mchandschuh
approved these changes
Aug 24, 2018
Martin-Molinero
pushed a commit
that referenced
this pull request
Feb 4, 2021
Merged
4 tasks
Martin-Molinero
pushed a commit
that referenced
this pull request
Mar 9, 2021
Martin-Molinero
pushed a commit
that referenced
this pull request
Apr 26, 2022
Reflect PR#8 MISSING CONVERTER.CS L516-528 Changes Reflect PR #14 Reflect PR #15 Reflect PR #19 Reflect PR #25 Reflect PR #34 Reflect PR #35 Implement List Conversion, Reflect PR #37 Tests Reflect PR #38 Partial: Assembly Manager Improvements Reflect PR #38 Reflect PR #42 KeyValuePairEnumerableObject Reflect PR #10 Runtime DecimalType Add TimeDelta and DateTime tests Fix DecimalConversion test for float conversion Converter mod tweaks Adjust a few broken PyTests Use _pydecimal to not interfere with Lean/decimal.py Add MethodBinder tests MethodBinder implicit resolution Fix bad cherry pick Refactoring precedence resolution Deal with operator binding Fix `TestNoOverloadException` unit test Fix for DomainReload tests Add InEquality Operator Test Dont PyObjects precedence in Operator methods Revert "Merge pull request pythonnet#1240 from danabr/auto-cast-ret-val-to-interface" This reverts commit 50d947f, reversing changes made to d44f1da. Fix Primitive Conversion to Int Post rebase fix Add PrimitiveIntConversion test Add test for interface derived classes Add to Authors.md Load in current directory into Python Path Include Python Lib in package Update as QuantConnect.PythonNet; include console exe in package Drop MaybeType from ClassManager for performance Package nPython from same configuration Address KWargs and Params; also cleanup Add unit tests Add pytest params unit test to testrunner Remove testing case from TestRuntime.cs Fix HandleParamsArray Test case Version bump Update QC Tests Refactor Params Fix Fix assembly info Handle breaking PyTests Cleanup Optimize Params Handling First reflection improvements Add TypeAccessor improvements and a bunch more tests More improvements Bump version to 2.0.2 Revert ClassManager changes Remove readonly Replace FastMember with Fasterflect Add global MemberGetter/MemberSetter cache Minor changes Make Fasterflect work with all regression tests Fix performance regressions Revert accidental pythonnet/runtime/.gitkeep removal Handle sending a python list to an enumerable expecting method - Converter with handle sending a python List to a method expecting a csharp enumerable. Adding unit test Bump version to 2.0.3 Update to net5.0 - Updating all projects to target net.50 - Remove domain test since it's not supported in net5.0 Bump pythonNet version 2.0.4 Add reproducing test Apply fix Catch implicit conversion throw Cleanup solution Cleanup V2 Assert Error message Small performance improvement Drop print statement from unit test Bump version to 2.0.5 Bump references to new version Fix for methods with different numerical precision overloads - Fix for methods with different numerical precision overloads. Method precedence will give higher priority to higher resolution numerical arguments. Adding unit test Version bump to 2.0.6 KeyValuePair conversion and performance - Improve DateTime conversion performance - Add support for KeyValuePair conversions - Minor improvements for convertions and method binder TypeManager and decimal improvements Reduce unrequired casting Version bump to 2.0.7 Apply fixes Project fix for linux systems Add unit test Converter cleanup More adjustments and fixes Add additional Py test & cleanup Use the generic match when others fail Add test for non-generic choice Address review Cleanup Version bump 2.0.8 Add performance test, also add caching Make Cache static to apply to all binders Make adjustments from testing Add test where overload exists with an already typed generic parameter use `ContainsGenericParameters` to check for unassigned generics Implement fix Add accompanying test Add additional tests Fix minor issue with py Date -> DateTime Refactor solution, use margs directly convert in ResolveGenericMethod Version Bump 2.0.9 Add missing exception clearing. Adding unit test Version bump 2.0.10 Handle readonly conversion to list. Adding unit tests Bump version to 2.0.11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DECREF'ing datetime timezone argument when DateTimeKind is Unspecified was causing
Fatal Python error: deallocating Nonebecause the object was set toRuntime.PyNone.Fixed the input to datetime constructor as we were passing milliseconds, where it should be microseconds.