Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Soon available filter #10380

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Soon available filter #10380

wants to merge 1 commit into from

Conversation

geogolem
Copy link
Contributor

This is a PR to replace: #5327

@github-actions github-actions bot added Area: UI Issue is related to UI, should also add the issue to the new UI project, if it isn't a bug. Area: API Issue is related to the API labels Aug 31, 2024
@geogolem geogolem mentioned this pull request Aug 31, 2024
Closed
@geogolem geogolem mentioned this pull request Aug 31, 2024
Open
@mynameisbogdan mynameisbogdan added the Status: Don't Merge Hold up - don't merge this label Oct 12, 2024
@geogolem geogolem force-pushed the SoonAvailableFilter branch 4 times, most recently from 82c0f9d to 8c32cb5 Compare January 17, 2025 20:53
@geogolem geogolem force-pushed the SoonAvailableFilter branch from 63a4aa1 to 35f95a1 Compare January 17, 2025 23:01
@mynameisbogdan
Copy link
Collaborator

To be honest I'm confused by this PR, what's the difference between IN_PAST = is_available is true and IN_FUTURE = is_available is false? Only the availability days?

@geogolem geogolem force-pushed the SoonAvailableFilter branch from bffe919 to 4ff7df9 Compare January 18, 2025 10:56
@geogolem
Copy link
Contributor Author

geogolem commented Jan 18, 2025 •
edited
Loading

To be honest I'm confused by this PR, what's the difference between IN_PAST = is_available is true and IN_FUTURE = is_available is false? Only the availability days?

@mynameisbogdan I think you are right (I'm not sure what I was thinking when I implemented 4 years ago)... I removed some extraneous code.

@geogolem
New Custom Filters based on Availability
358bfab 
Radarr#2074

make the UI take into account AvailabilityDelay
to make it consistent with RSS Decision Engine

add custom filter options for minimumAvailabilityDate
with and without Delay

Simplify the filter names.
ConsideredAvailable ---> DateConsideredAvailable  (these always take into account the delay)
MinimumAvailability ---> MinimumAvailabilityDate  (these never take into account delay)

if delay = 0 .. the 2 dates above are identical.
if delay = 0, MimimumAvailabilityDate will be 1 of InCinemas, Announced or Physical/Digital (Released) dates

Add ability to make the custom filter dates relative to
currentdate

DateConsideredAvailable tooltip on NotAvailable
@geogolem geogolem force-pushed the SoonAvailableFilter branch from 4ff7df9 to 358bfab Compare January 18, 2025 11:09
@geogolem
Copy link
Contributor Author

@mynameisbogdan : looking forward to your feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mynameisbogdan mynameisbogdan mynameisbogdan left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Area: API Issue is related to the API Area: UI Issue is related to UI, should also add the issue to the new UI project, if it isn't a bug. Status: Don't Merge Hold up - don't merge this
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geogolem @mynameisbogdan