New: Lists retroactively apply tags #10537
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 4, 2024 13:47
This commit introduces a new feature allowing tags to be retroactively applied to movies already in the database. Changes include database migration for the new column, updates to the frontend to manage this feature, and backend logic to handle retroactive tagging.
Moved and added translations for retroactive tag application. Corrected minor organizational issues in the JSON file to maintain consistency.
|
I got this working. Still not sure how to unit test it, and need to keep looking to see if i missed any documentation This addresses issue #10507 |
|
Fixes #5299 |
|
fixes #6464 |
bakerboy448
reviewed
Oct 7, 2024
moving to another PR
configured to auto-detect if building on an ARM mac or not
|
It doesn't look like there are any wiki pages that would need to be updated. please correct if i am wrong, i added the columns to the two modal screens. |
Enhanced the migration script to include the RetroApplyTags column for the Notifications and Indexers tables, ensuring consistent data structure across related tables. This column is added with a default value of 0, similar to the ImportLists table.
Changed the RetroApplyTags column type in ImportLists to Boolean. Added RetroApplyTags column to Notifications, Indexers, and DownloadClients with a default value of false. This ensures consistent behavior across these tables.
… feature/retro_add_tags
|
Yea I'm rethinking this solution a little bit. I hate adding those 3 additional columns just cuz I added a field. I'm going to look at the interfaces harder and see if I can come up with a better way. |
|
When/If i figure out a way to remove those unneeded fields, is there anything else that causes alarm here? I'd really like to get this submitted. There's another feature request i wanted to work on this would be integrated with. |
Removed the RetroApplyTags field from ProviderDefinition, Notifications, Indexers, DownloadClients, and relevant API resources. RetroApplyTags is now exclusively managed within ImportListDefinition.
The RetroApplyTags property has been removed to streamline the ProviderResource class. This change will help to reduce unnecessary attributes, simplifying the overall codebase.
This change introduces a new boolean field called retroApplyTags to the Radarr API V3. It ensures that the API schema includes this property for any relevant operations. This helps in handling retroactive tag application within the system.
The retroApplyTags property was deleted to streamline the API schema. This change ensures the JSON specification is more concise and easier to maintain.
|
What else needs completed to merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Database Migration
YES - 241
Description
This request gives the import lists system the ability to retroactively apply tags to existing movies in the database.
Screenshot (if UI related)
Todos
Issues Fixed or Closed by this PR