-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import Lists take Collection membership into account #10802
Open
bruceharrison1984
wants to merge
15
commits into
Radarr:develop
Choose a base branch
from
bruceharrison1984:develop
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+135
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any thoughts or comments on this? The use case seems valid considering you can configure Import Lists to download all related movies in a collection. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: API
Issue is related to the API
Area: Import Lists
Issue is related to Importing from Lists
Area: UI
Issue is related to UI, should also add the issue to the new UI project, if it isn't a bug.
Status: Don't Merge
Hold up - don't merge this
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Database Migration
NO
Description
This gives Import List Sync the ability to account for Collection membership. Currently, selecting an option(
Remove Movie and Delete Files
) that allows for Radarr to alter media based on lists completely ignores that Collections are a thing, and movies will be removed unless explicitly part of an Import List. The can cause a scenario where Collections are automatically downloaded, then subsequently deleted every single time the Sync process runs, causing excessive and wasteful network I/O and disk wearThis adds additional logic(as well as a toggle) that prevents Radarr from making changes to movies that are not explicitly on an Import List, but are part of a Collection that includes at least one movie that is on an Import list. This facilitates full automation of downloading(and retaining) entire Collections so long as a single movie within the collection appears on an Import List.
false
by default which explicitly preserves the original behavior prior to this change.This could make overall syncs take longer due to additional checks, however since many movies will be potentially ignored and we cache all collection data upfront, it is likely a wash in terms of performance.
Screenshot (if UI related)
Todos
Issues Fixed or Closed by this PR