Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import Lists take Collection membership into account #10802

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from

Conversation

bruceharrison1984
Copy link

@bruceharrison1984 bruceharrison1984 commented Dec 30, 2024

Database Migration

NO

Description

This gives Import List Sync the ability to account for Collection membership. Currently, selecting an option(Remove Movie and Delete Files) that allows for Radarr to alter media based on lists completely ignores that Collections are a thing, and movies will be removed unless explicitly part of an Import List. The can cause a scenario where Collections are automatically downloaded, then subsequently deleted every single time the Sync process runs, causing excessive and wasteful network I/O and disk wear

This adds additional logic(as well as a toggle) that prevents Radarr from making changes to movies that are not explicitly on an Import List, but are part of a Collection that includes at least one movie that is on an Import list. This facilitates full automation of downloading(and retaining) entire Collections so long as a single movie within the collection appears on an Import List.

  • As implemented here, the Ignore Collections option is set to false by default which explicitly preserves the original behavior prior to this change.
  • Enabling the new option means that so long as a single movie within a Collection is on an Import List, all other movies within the Collection will not be touched by the sync process.

This could make overall syncs take longer due to additional checks, however since many movies will be potentially ignored and we cache all collection data upfront, it is likely a wash in terms of performance.

Screenshot (if UI related)

image

Todos

  • Tests
  • Translation Keys (./src/NzbDrone.Core/Localization/Core/en.json)
  • Wiki Updates

Issues Fixed or Closed by this PR

@github-actions github-actions bot added Area: UI Issue is related to UI, should also add the issue to the new UI project, if it isn't a bug. Area: API Issue is related to the API Area: Import Lists Issue is related to Importing from Lists labels Dec 30, 2024
@mynameisbogdan mynameisbogdan added the Status: Don't Merge Hold up - don't merge this label Dec 30, 2024
@bruceharrison1984
Copy link
Author

Any thoughts or comments on this?

The use case seems valid considering you can configure Import Lists to download all related movies in a collection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: API Issue is related to the API Area: Import Lists Issue is related to Importing from Lists Area: UI Issue is related to UI, should also add the issue to the new UI project, if it isn't a bug. Status: Don't Merge Hold up - don't merge this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exclude movies added from collections in Clean Library Settings
2 participants