New: extract "additional" parameters from the release title, in order to be able to apply custom formats to them #10881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
February 4, 2025 23:27
…ase title parameters
… the TitleExtraParameters field of the ParsedMovieInfo
src/NzbDrone.Core/CustomFormats/Specifications/ReleaseTitleSpecification.cs
Outdated
Show resolved
Hide resolved
|
Naming suggestion: something beside extra as for search that will mean extras like movie extras etc. should be more precise/descriptive me thinks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Database Migration
NO
Description
The goal is to include potential file extensions in the calculation of the custom formats score. This bypasses the issue where .xvid is treated as an extension and thus excluded from the release title, resulting in different custom format scores in cases that look similar. Managed this way also makes it possible in the future to completely separate the custom format application only to the extra parameters, without applying them to the release title. I would think that this would also solve some extreme cases where a custom format is matched to the movie title.
To take into consideration
I have added the extra parameters regex only to the normal movie format regex. It might be needed to add it to other movie formats.
Issues Fixed or Closed by this PR