New: Indexer condition Custom Format #9417
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements a new Custom Format condition to match on the specific Indexer that was used to grab the content. The Indexer ID is the property used for the comparision (and not the Indexer Name), however, the condition editor GUI displays the Indexer Name for a more user friendly experience (instead of the internal Indexer ID). The ability to store in the database the Indexer ID was also added to Blocklist and MovieFile items. The Indexer ID is also exposed and tracked in all applicable History events.
This commit implements three basic unit tests for the new "Indexer" Custom Format (comparing Indexer IDs).
Fixed MovieHistory data dictionary key lookup to "indexerId" (case mismatch) Added IndexerID lookup functionality (so that custom formats and their scores can later be calculated) for downloads that are in the Queue
|
Also consider #7912 as a condition with this pr <3 |
I can definitely see the similarities between the Indexer condition and the feature you mentioned. I think adding it won't be too tough since it's similar to what I did for the Indexer. But, before I dive into the Downloader/Protocol side of things, I want to wait for a review from the Arr devs on my Indexer condition implementation. Just want to double-check I'm on the right track before working on more code. |
1 task
|
I think this could be very helpful. Anything I can do to help speed this PR along? |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Database Migration
YES - Migration 234 - Adds a "IndexerId" column to the "Blocklist" and "MovieFiles" tables to support evaluating this new indexer Custom Format based on the saved value
Description
Implement a new Custom Format condition based on the indexer used to grab the specific content. This allows for more granular priority setting based on indexers, and also now facilitates defining custom conditions (using the other Custom Format conditions) that are specific to a or multiple indexers.
Note: It took a bit of time to familiarize myself with the structure of the project, and understand how it all works. Therefore, the way I implemented the dropdown for selecting the Indexer (or any other part of my changes for that matter), may not be optimal/ideal; alternative suggestions are welcome.
Issues Fixed or Closed by this PR