improved in out degree performance #2757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 92.29% // Head: 92.36% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2757 +/- ##
==========================================
+ Coverage 92.29% 92.36% +0.06%
==========================================
Files 264 264
Lines 25215 25254 +39
==========================================
+ Hits 23273 23325 +52
+ Misses 1942 1929 -13
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
iddm
approved these changes
Dec 12, 2022
iddm
reviewed
Dec 12, 2022
iddm
previously approved these changes
Dec 12, 2022
| // outgoing edges | ||
| //---------------------------------------------------------------------- | ||
|
|
||
| // TODO: revisit once we get rid of MULTI-EDGE hack |
There was a problem hiding this comment.
Should we anticipate any changes regarding this "TODO" in this PR or later?
There was a problem hiding this comment.
probably later down the road
raz-mon
previously approved these changes
Dec 15, 2022
removed unused `info`
raz-mon
pushed a commit
that referenced
this pull request
Dec 20, 2022
* improved in out degree performance * Update graph.c removed unused `info`
raz-mon
pushed a commit
that referenced
this pull request
Dec 20, 2022
* improved in out degree performance * Update graph.c removed unused `info`
AviAvni
added a commit
that referenced
this pull request
Dec 26, 2022
* Fix type mismatch error message (#2691) * Add function SIType_ToMultipleTypeString() * Test type mismatch * Fix test_query_validation assert messages * Remove support to not used types * Remove last comma from list of types * Fix type mismatch test * work on comparison (#1923) * work on comparison * fix merge * simplify * add test * fix test * address review * work on comparison (#1923) * work on comparison * fix merge * simplify * add test * fix test * address review * More readable code * Fix SIType_ToMultipleTypeString() ASSERT() * SIType_ToMultipleTypeString() support to all types * Iterate over SITypes using currentType * Remove outdated comment * Switch to a stack allocated buffer * Use __builtin_popcount() * Fix test hasLabels() mismatch type * Use constant for buf size * Revert "Use constant for buf size" This reverts commit 69f34d5. * Remove bytesWritten arg * Use named constant for buffer size * SIType_ToMultipleTypeString() use 3 loops Co-authored-by: Avi Avni <avi.avni@gmail.com> * timeout fix (#2742) * timeout fix * Added a test * Fix printing of the cond-traverse and expand-into operations. (#2727) * Fixed printing of cond-traverse and expand-into * Added tests * WIP addressing comments * taking labels from corresponding AlgebraicExpression * fix profile test * Reverted previous changes * Addressing comments * WIP freeing memory * Fix leak * WIP leak fix * Leak fix * Fix crash. * Small fix * clean ups Co-authored-by: Victor Polevoy <fx@thefx.co> Co-authored-by: swilly22 <roi@redislabs.com> Co-authored-by: Avi Avni <avi.avni@gmail.com> * Inherit attribute set (#2751) * inherit attribute-set when creating a new node * fix build * clean Co-authored-by: swilly22 <roi@redislabs.com> * replicate command run on main thread (#2754) * replicate command run on main thread * address review * fix * improved in out degree performance (#2757) * improved in out degree performance * Update graph.c removed unused `info` * bump version 2.10.5 * Fix test * Update release.json (#2771) adding focal to enterprise qa * Update RS_VERSIONS (#2776) add cluster versions for release testing Co-authored-by: nafraf <nafraf@users.noreply.github.com> Co-authored-by: Avi Avni <avi.avni@gmail.com> Co-authored-by: Victor Polevoy <fx@thefx.co> Co-authored-by: swilly22 <roi@redislabs.com> Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> Co-authored-by: TomerHekmati <72793005+TomerHekmati@users.noreply.github.com>
AviAvni
added a commit
that referenced
this pull request
Dec 26, 2022
* UNWIND an expression that is not a list (#2650) * _initList: Create list for not list values * Add test_unwind_clause.py * tck test unwinding null * Fix unwind tests * Fix test unwind null Co-authored-by: Avi Avni <avi.avni@gmail.com> * Allow update properties to NULL (#2665) * Allow update properties to NULL * Test remove null attribute MERGE ON CREATE SET * Fix Duplicate reports when matching relationship type :R|R (#2674) * _QueryGraphAddEdge don't add duplicated reltypeIDs * Prevent duplicated reltypes when no schema found Co-authored-by: Avi Avni <avi.avni@gmail.com> * add reference entities in unwind (#2692) * fix crash using freed values (#2695) * fix crash using freed values * add comment * bug fix validate MERGE SET property: issue: 2637 (#2684) Co-authored-by: Avi Avni <avi.avni@gmail.com> * fix crash of aggregation function in reduce (#2696) * remove old parameter syntax (#2697) * remove old parameter syntax * fix test * fix tck * fix * Fix optimize-label-scan (#2711) * Replacement AlgebraicExpression fixed to original label * Added test * Added comments * Update test_optimizations_plan.py * Update optimize_label_scan.c Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> Co-authored-by: Avi Avni <avi.avni@gmail.com> * Updated readies (fix for getpy3 on xenial) (#2720) * timeout fix (#2742) * timeout fix * Added a test * replicate command run on main thread (#2754) * replicate command run on main thread * address review * fix * improved in out degree performance (#2757) * improved in out degree performance * Update graph.c removed unused `info` * bump version 2.8.21 * cp fixes * Update release.json (#2771) adding focal to enterprise qa * leak fix * leak fix2 * leak fix3 * Update RS_VERSIONS (#2776) add cluster versions for release testing * leak fix * test fix Co-authored-by: nafraf <nafraf@users.noreply.github.com> Co-authored-by: Avi Avni <avi.avni@gmail.com> Co-authored-by: OfirMos <82366525+OfirMos@users.noreply.github.com> Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> Co-authored-by: Rafi Einstein <raffapen@outlook.com> Co-authored-by: TomerHekmati <72793005+TomerHekmati@users.noreply.github.com>
pnxguide
pushed a commit
to CMU-SPEED/RedisGraph
that referenced
this pull request
Mar 22, 2023
* improved in out degree performance * Update graph.c removed unused `info`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2753
MATCH (a) RETURN outDegree(a), inDegree(a)Previous implementation would extract
a'sincoming / outgoing edges into an array just to get its length and soon after discard it which is a waste. This new implementation doesn't extracts any edges but simply counts.FYI with @AviAvni new design of NxM Relation matrices (N #nodes, M #edges) we get rid of Multi edge arrays and can simplify this change to a straight forward row reduction.
Quick benchmark:
Compute out degree of a node with 1M outgoing edges
This PR 0.2ms
Current
Master20ms100X improvement