Fix right(), left() length validation #2801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @nafraf |
Codecov ReportBase: 92.16% // Head: 92.18% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2801 +/- ##
==========================================
+ Coverage 92.16% 92.18% +0.02%
==========================================
Files 264 264
Lines 25093 25097 +4
==========================================
+ Hits 23126 23136 +10
+ Misses 1967 1961 -6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@LiorKogan Thanks. Is this the expected output in this case? Or the expected result is NULL? |
Haha... The result is this pathological case should actually be null... I guess this is just the order of the checks... |
|
@LiorKogan |
AviAvni
reviewed
Dec 29, 2022
| if(SIValue_IsNull(argv[0])) return SI_NullVal(); | ||
|
|
||
| int64_t newlen = -1; | ||
| if(SI_TYPE(argv[1]) == T_INT64) { |
There was a problem hiding this comment.
why not removing the null option for the second argument from the registration and then this if is not needed?
There was a problem hiding this comment.
Because if null option is removed for second argument, the output of right(null, null) will be an error of type mismatch, but the expected output is NULL, without error.
raz-mon
pushed a commit
that referenced
this pull request
Jan 25, 2023
* Fix AR_LEFT, AR_RIGHT length validation * Test mistmatch type and fix error message * left(), right(): NULL is a valid type for lenght * Fix argument validation Co-authored-by: Avi Avni <avi.avni@gmail.com>
AviAvni
added a commit
that referenced
this pull request
Jan 25, 2023
* Fix toInteger() and toIntegerOrNull() don't convert Booleans (#2797) * AR_TOINTEGER: add case for type T_BOOL * skip [8] toInteger() failing on invalid arguments * Update TypeConversion2.feature Co-authored-by: Avi Avni <avi.avni@gmail.com> * Fix right(), left() length validation (#2801) * Fix AR_LEFT, AR_RIGHT length validation * Test mistmatch type and fix error message * left(), right(): NULL is a valid type for lenght * Fix argument validation Co-authored-by: Avi Avni <avi.avni@gmail.com> * fix using timeout max as default when default not configured (#2808) * fix using timeout max as default when default not configured * fix * do not cache query params (#2803) * do not cache query params * address PR comments * fix leak * fix test * convert params to SIValues * wip * delay freeing of parsed params to after the query is parsed * free parse params when freeing AST * revert changes to ast_validations.c * revert arithmetic_expression_construct changes * emit an error when param value eval fails Co-authored-by: Avi Avni <avi.avni@gmail.com> * fix multi-hop traverse with name path (#2743) * Add varLen property to QGEdge * Test variable-length edge queries * Fix spacing * Fix test, remove direction * Fix test * Test zero length edge * Init varLen in QGEdge_New() * rename varLen to rangeLen * Rewrite test11_range_length_edges() * Use QGEdge_VariableLength() and QGEdge_RangeLength * Replace QGEdge_RangeLength() by QGEdge_LengthOne() * rename function Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> Co-authored-by: Avi Avni <avi.avni@gmail.com> * indegree(), outdegree() - accept array of strings (#2807) * _AR_NodeDegree() support T_ARRAY argument * Add tests * Fix argument validation * Free array in case of error detected. * Duplicate comments and use siarray.array[i] * Update AR_IN() to use SI_ArrayContainsValue() * Validate comparedNull pointer * Support only the following two signatures: * Test indegree() wrong argument number * Test wrong signature: string and list * clean * revert Co-authored-by: Avi Avni <avi.avni@gmail.com> * Add ipv6 capability (#2842) * fix heap remove item (#2827) * fix heap remove item * remove utf8 deps * add test * wip * wip * all unit tests pass * heap remove element should use pointer cmp instead of cmp cb * spaces to tabs Co-authored-by: swilly22 <roi@redislabs.com> Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> * bump version 2.10.6 * Improve edge deletion performance (#2758) * improve edge deletion * update simple timer * improve edge deletion perf * fix build * fix test * fix test * clean * address review Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> * update ramp Co-authored-by: nafraf <nafraf@users.noreply.github.com> Co-authored-by: Avi Avni <avi.avni@gmail.com> Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> Co-authored-by: Guy Korland <gkorland@gmail.com> Co-authored-by: swilly22 <roi@redislabs.com>
pnxguide
pushed a commit
to CMU-SPEED/RedisGraph
that referenced
this pull request
Mar 22, 2023
* Fix AR_LEFT, AR_RIGHT length validation * Test mistmatch type and fix error message * left(), right(): NULL is a valid type for lenght * Fix argument validation Co-authored-by: Avi Avni <avi.avni@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are to fix bug #2798.
Changes:
left(),right(), andsubstring()Sample output:
Edit: Sample output updated with changes f917b06